Messages in this thread | | | From | Sumit Semwal <> | Date | Fri, 11 Aug 2017 21:25:00 +0530 | Subject | Re: [PATCH] selftests: memfd: Align STACK_SIZE for ARM AArch64 system |
| |
Hello Orson,
Thanks for the patch.
On 10 August 2017 at 16:34, Orson Zhai <orson.zhai@linaro.org> wrote: > The stack size should be 16 bytes aligned in arm64 system. The similar > patch has been merged already. > >> <commit id: 1f78dda2cf5e4eeb00aee2a01c9515e2e704b4c0> >> selftests: memfd_test: Revised STACK_SIZE to make it 16-byte aligned >> >> There is a mandate of 16-byte aligned stack on AArch64 [1], so the >> STACK_SIZE here should also be 16-byte aligned, otherwise we would >> get an error when calling clone(). >> >> [1] http://lxr.free-electrons.com/source/arch/arm64/kernel/process.c#L265 >> >> Signed-off-by: Chunyan Zhang <zhang.chunyan@linaro.org> >> Acked-by: Arnd Bergmann <arnd@arndb.de> >> Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com> > > Signed-off-by: Orson Zhai <orson.zhai@linaro.org> Please feel free to add my Reviewed-by: Sumit Semwal <sumit.semwal@linaro.org> > --- > tools/testing/selftests/memfd/fuse_test.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/memfd/fuse_test.c b/tools/testing/selftests/memfd/fuse_test.c > index 67908b18f035..7f3617274bf5 100644 > --- a/tools/testing/selftests/memfd/fuse_test.c > +++ b/tools/testing/selftests/memfd/fuse_test.c > @@ -33,7 +33,7 @@ > #include <unistd.h> > > #define MFD_DEF_SIZE 8192 > -#define STACK_SIZE 65535 > +#define STACK_SIZE 65536 > > static int sys_memfd_create(const char *name, > unsigned int flags) > -- > 2.12.2 >
Best, Sumit.
| |