lkml.org 
[lkml]   [2017]   [Aug]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 4.4 01/58] parisc: Increase thread and stack size to 32kb
From
Date
On 11.08.2017 03:33, Ben Hutchings wrote:
> On Wed, 2017-08-09 at 12:41 -0700, Greg Kroah-Hartman wrote:
>> 4.4-stable review patch. If anyone has any objections, please let me know.
>>
>> ------------------
>>
>> From: Helge Deller <deller@gmx.de>
>>
>> commit 8f8201dfed91a43ac38c899c82f81eef3d36afd9 upstream.
>>
>> Since kernel 4.11 the thread and irq stacks on parisc randomly overflow
>> the default size of 16k. The reason why stack usage suddenly grew is yet
>> unknown.
>
> So we don't need this for 4.4.

Correct.

I had Cc: stable@vger.kernel.org # 4.11+
in the commit itself:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=8f8201dfed91a43ac38c899c82f81eef3d36afd9

Helge

>
> Ben.
>
>> Signed-off-by: Helge Deller <deller@gmx.de>
>> Signed-off-by: Helge Deller <deller@gmx.de>
>> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>>
>> ---
>> arch/parisc/include/asm/thread_info.h | 2 +-
>> arch/parisc/kernel/irq.c | 2 +-
>> 2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> --- a/arch/parisc/include/asm/thread_info.h
>> +++ b/arch/parisc/include/asm/thread_info.h
>> @@ -34,7 +34,7 @@ struct thread_info {
>>
>> /* thread information allocation */
>>
>> -#define THREAD_SIZE_ORDER 2 /* PA-RISC requires at least 16k stack */
>> +#define THREAD_SIZE_ORDER 3 /* PA-RISC requires at least 32k stack */
>> /* Be sure to hunt all references to this down when you change the size of
>> * the kernel stack */
>> #define THREAD_SIZE (PAGE_SIZE << THREAD_SIZE_ORDER)
>> --- a/arch/parisc/kernel/irq.c
>> +++ b/arch/parisc/kernel/irq.c
>> @@ -380,7 +380,7 @@ static inline int eirr_to_irq(unsigned l
>> /*
>> * IRQ STACK - used for irq handler
>> */
>> -#define IRQ_STACK_SIZE (4096 << 2) /* 16k irq stack size */
>> +#define IRQ_STACK_SIZE (4096 << 3) /* 32k irq stack size */
>>
>> union irq_stack_union {
>> unsigned long stack[IRQ_STACK_SIZE/sizeof(unsigned long)];
>>
>>
>

\
 
 \ /
  Last update: 2017-08-11 09:22    [W:0.123 / U:0.492 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site