Messages in this thread | | | From | Vivien Didelot <> | Subject | Re: [PATCH net-next 10/11] net: dsa: mv88e6xxx: remove EEE support | Date | Tue, 01 Aug 2017 16:08:15 -0400 |
| |
Vivien Didelot <vivien.didelot@savoirfairelinux.com> writes:
> Second option is: we keep it KISS and let the driver define its noop, > but as I explain, it is confusing, especially for the get operation.
In fact we should be good because the DSA layer will call ds->ops->{g,s}et_mac_eee before phy_ethtool_{g,s}et_eee, so if the DSA driver didn't touch the ethtool_eee structure, the PHY ops will anyway.
I'm sending a v2 right away.
Thanks,
Vivien
| |