Messages in this thread | | | From | Joel Fernandes <> | Date | Fri, 7 Jul 2017 15:07:09 -0700 | Subject | Re: [RFC PATCH v1 3/8] sched/cpufreq_schedutil: make worker kthread be SCHED_DEADLINE |
| |
Hi,
On Fri, Jul 7, 2017 at 2:58 PM, Steven Rostedt <rostedt@goodmis.org> wrote: > On Fri, 07 Jul 2017 15:11:45 +0200 > "Rafael J. Wysocki" <rjw@rjwysocki.net> wrote: > >> On Friday, July 07, 2017 11:53:16 AM Juri Lelli wrote: >> > On 07/07/17 12:46, Thomas Gleixner wrote: >> > > On Fri, 7 Jul 2017, Juri Lelli wrote: >> > > > How about SCHED_FLAG_SUGOV then? >> > > >> > > I know sugo della carne, but what's sugo V? >> > > >> > >> > Right.. can't really help not thinking about the same (especially close >> > to lunch) :) >> > >> > But the abbreviation stands for SchedUtil GOVernor (AFAIK). We already >> > have a SUGOV_KTHREAD_PRIORITY (that I just noticed I need to remove BTW) >> > in sched/cpufreq_schedutil.c. >> >> SCHED_FLAG_CPUFREQ_WORKER comes to mind, but it's somewhat long. >> > > It is rather long. Although I actually hate the SUGOV, it is easily > grepable. Just comment what it stands for. We can always change it > later.
I was thinking why not just SCHED_FLAG_CPUFREQ. That says its for cpufreq purposes, and is a bit self-documenting. "WORKER" is a bit redundant and can be dropped in my opinion.
thanks,
-Joel
| |