lkml.org 
[lkml]   [2017]   [Jul]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 8/8] Staging: lustre :lustre: include :lustre_compat.h: Prefer using the BIT macro
On Thu, Jul 6, 2017 at 9:13 AM, Jaya Durga <rjdurga@gmail.com> wrote:
> Subject: Staging: lustre :lustre: include :lustre_compat.h: Prefer using the BIT macro

Don't overdo it ;-).

Subject: staging: lustre: lustre_compat.h: Prefer using the BIT macro

> Replace all instances of (1 << 27) with BIT(27) to fix
> checkpatch check messages

While it may technically be true that this one instance is every
instance of (1<<27) there is in lustre_compat.h, I must say I expected
a bigger patch when I saw "replace all instances".


> Signed-off-by: Jaya Durga <rjdurga@gmail.com>
> ---
> drivers/staging/lustre/lustre/include/lustre_compat.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/lustre/lustre/include/lustre_compat.h b/drivers/staging/lustre/lustre/include/lustre_compat.h
> index da9ce19..686a251 100644
> --- a/drivers/staging/lustre/lustre/include/lustre_compat.h
> +++ b/drivers/staging/lustre/lustre/include/lustre_compat.h
> @@ -43,7 +43,7 @@
> * set ATTR_BLOCKS to a high value to avoid any risk of collision with other
> * ATTR_* attributes (see bug 13828)
> */
> -#define ATTR_BLOCKS (1 << 27)
> +#define ATTR_BLOCKS BIT(27)
>
> #define current_ngroups current_cred()->group_info->ngroups
> #define current_groups current_cred()->group_info->small_block
> --
> 1.9.1
>
> _______________________________________________
> devel mailing list
> devel@linuxdriverproject.org
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

\
 
 \ /
  Last update: 2017-07-06 09:24    [W:0.058 / U:0.320 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site