lkml.org 
[lkml]   [2017]   [Jul]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] drm/rockchip: fix NULL check on devm_kzalloc() return value
From
Date
On 2017年07月07日 05:58, Gustavo A. R. Silva wrote:
> The right variable to check here is port, not dp.
>
> This issue was detected using Coccinelle and the following semantic patch:
>
> @@
> expression x;
> identifier fld;
> @@
>
> * x = devm_kzalloc(...);
> ... when != x == NULL
> x->fld
>
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>

Thanks for the fix,

Acked-by: Mark Yao <mark.yao@rock-chips.com>

> ---
> drivers/gpu/drm/rockchip/cdn-dp-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/rockchip/cdn-dp-core.c b/drivers/gpu/drm/rockchip/cdn-dp-core.c
> index 14fa1f8..9b0b058 100644
> --- a/drivers/gpu/drm/rockchip/cdn-dp-core.c
> +++ b/drivers/gpu/drm/rockchip/cdn-dp-core.c
> @@ -1195,7 +1195,7 @@ static int cdn_dp_probe(struct platform_device *pdev)
> continue;
>
> port = devm_kzalloc(dev, sizeof(*port), GFP_KERNEL);
> - if (!dp)
> + if (!port)
> return -ENOMEM;
>
> port->extcon = extcon;


--
Mark Yao


\
 
 \ /
  Last update: 2017-07-07 02:57    [W:0.043 / U:6.796 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site