lkml.org 
[lkml]   [2017]   [Jul]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [f2fs-dev] [PATCH] f2fs: relax permission for atomic/volatile ioctls
From
Date
On 2017/7/6 10:23, Jaegeuk Kim wrote:
> This patch allows atomic/volatile ioctls for sqlite under sdcardfs.

Out of curiosity, we will lose some capable when passing through sdcardfs?

Thanks,

>
> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>> ---
> fs/f2fs/file.c | 15 ---------------
> 1 file changed, 15 deletions(-)
>
> diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
> index f5d6357e8360..dd8f5d2caa48 100644
> --- a/fs/f2fs/file.c
> +++ b/fs/f2fs/file.c
> @@ -1587,9 +1587,6 @@ static int f2fs_ioc_start_atomic_write(struct file *filp)
> struct inode *inode = file_inode(filp);
> int ret;
>
> - if (!inode_owner_or_capable(inode))
> - return -EACCES;
> -
> if (!S_ISREG(inode->i_mode))
> return -EINVAL;
>
> @@ -1636,9 +1633,6 @@ static int f2fs_ioc_commit_atomic_write(struct file *filp)
> struct inode *inode = file_inode(filp);
> int ret;
>
> - if (!inode_owner_or_capable(inode))
> - return -EACCES;
> -
> ret = mnt_want_write_file(filp);
> if (ret)
> return ret;
> @@ -1672,9 +1666,6 @@ static int f2fs_ioc_start_volatile_write(struct file *filp)
> struct inode *inode = file_inode(filp);
> int ret;
>
> - if (!inode_owner_or_capable(inode))
> - return -EACCES;
> -
> if (!S_ISREG(inode->i_mode))
> return -EINVAL;
>
> @@ -1707,9 +1698,6 @@ static int f2fs_ioc_release_volatile_write(struct file *filp)
> struct inode *inode = file_inode(filp);
> int ret;
>
> - if (!inode_owner_or_capable(inode))
> - return -EACCES;
> -
> ret = mnt_want_write_file(filp);
> if (ret)
> return ret;
> @@ -1736,9 +1724,6 @@ static int f2fs_ioc_abort_volatile_write(struct file *filp)
> struct inode *inode = file_inode(filp);
> int ret;
>
> - if (!inode_owner_or_capable(inode))
> - return -EACCES;
> -
> ret = mnt_want_write_file(filp);
> if (ret)
> return ret;
>

\
 
 \ /
  Last update: 2017-07-07 02:05    [W:0.047 / U:19.636 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site