lkml.org 
[lkml]   [2017]   [Jul]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 2/2] pinctrl: sunxi: add support of R40 to A10 pinctrl driver
From


于 2017年7月7日 GMT+08:00 上午4:50:30, Maxime Ripard <maxime.ripard@free-electrons.com> 写到:
>On Thu, Jul 06, 2017 at 10:28:22PM +0800, Icenowy Zheng wrote:
>> SUNXI_PIN(SUNXI_PINCTRL_PIN(B, 0),
>> SUNXI_FUNCTION(0x0, "gpio_in"),
>> SUNXI_FUNCTION(0x1, "gpio_out"),
>> - SUNXI_FUNCTION(0x2, "i2c0")), /* SCK */
>> + SUNXI_FUNCTION(0x2, "i2c0"), /* SCK */
>> + SUNXI_FUNCTION_VARIANT(0x3,
>> + "pll_lock_dbg",
>> + PINCTRL_SUN8I_R40)),
>
>You have a number of lines where the wrapping is not consistent with
>the rest, such as this one, but also...

I think this one is because of extraordinary function name.

>
>> SUNXI_PIN(SUNXI_PINCTRL_PIN(B, 20),
>> SUNXI_FUNCTION(0x0, "gpio_in"),
>> SUNXI_FUNCTION(0x1, "gpio_out"),
>> - SUNXI_FUNCTION(0x2, "i2c2")), /* SCK */
>> + SUNXI_FUNCTION(0x2, "i2c2"), /* SCK */
>> + SUNXI_FUNCTION_VARIANT(0x4,
>> + "pwm", /* PWM4 */
>> + PINCTRL_SUN8I_R40)),
>
>... this one for example. Please fix this.
>
>Looks good otherwise.
>
>Maxime

\
 
 \ /
  Last update: 2017-07-07 01:14    [W:0.043 / U:5.704 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site