lkml.org 
[lkml]   [2017]   [Jul]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] trace-cmd: replace show_file() -> show_instance_file()
On Mon,  5 Jun 2017 11:31:18 +0200
Federico Vaga <federico.vaga@vaga.pv.it> wrote:

> show_file(name) and show_instance_file(&top_instance, name) are
> equivalent.
>
> Remove the show_file() function in order to have a single function for
> this task.

Actually I find nothing wrong with having a helper function like this.
IIRC, show_file() was first, and then show_instance_file() came later.
There's some files that only exist for the top_instance, and I like the
fact that this is annotated that way.

I'm curious to know what the benefit of removing show_file() is?

-- Steve


>
> Signed-off-by: Federico Vaga <federico.vaga@vaga.pv.it>
> ---
> trace-list.c | 21 ++++++---------------
> trace-local.h | 2 --
> trace-show.c | 18 ++----------------
> trace-snapshot.c | 2 +-
> 4 files changed, 9 insertions(+), 34 deletions(-)
\

\
 
 \ /
  Last update: 2017-07-07 00:30    [W:0.062 / U:0.184 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site