lkml.org 
[lkml]   [2017]   [Jul]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V1 5/5] spmi: pmic-arb: use irq_chip callback to set spmi irq wakeup capability
On 07/03, Kiran Gunda wrote:
> diff --git a/drivers/spmi/spmi-pmic-arb.c b/drivers/spmi/spmi-pmic-arb.c
> index 5285245..2d2e39c 100644
> --- a/drivers/spmi/spmi-pmic-arb.c
> +++ b/drivers/spmi/spmi-pmic-arb.c
> @@ -621,6 +621,19 @@ static int qpnpint_irq_set_type(struct irq_data *d, unsigned int flow_type)
> return 0;
> }
>
> +static int qpnpint_irq_set_wake(struct irq_data *d, unsigned int on)
> +{
> + struct spmi_pmic_arb *pmic_arb = irq_data_get_irq_chip_data(d);
> + int ret;
> +
> + if (on)
> + ret = enable_irq_wake(pmic_arb->irq);
> + else
> + ret = disable_irq_wake(pmic_arb->irq);

Could be simplified to

return irq_set_irq_wake(pmic_arb->irq, on);

?

> +
> + return ret;
> +}
> +
> static int qpnpint_get_irqchip_state(struct irq_data *d,
> enum irqchip_irq_state which,
> bool *state)

--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

\
 
 \ /
  Last update: 2017-07-06 08:47    [W:0.085 / U:0.176 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site