lkml.org 
[lkml]   [2017]   [Jul]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] integrity: get rid of unneeded initializations in integrity_iint_cache entries
Quoting Jeff Layton (jlayton@kernel.org):
> From: Jeff Layton <jlayton@redhat.com>
>
> The init_once routine memsets the whole object to 0, and then
> explicitly sets some of the fields to 0 again. Just remove the explicit
> initializations.
>
> Signed-off-by: Jeff Layton <jlayton@redhat.com>

Reviewed-by: Serge Hallyn <serge@hallyn.com>

> ---
> security/integrity/iint.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/security/integrity/iint.c b/security/integrity/iint.c
> index 6fc888ca468e..187b7cb378be 100644
> --- a/security/integrity/iint.c
> +++ b/security/integrity/iint.c
> @@ -153,14 +153,11 @@ static void init_once(void *foo)
> struct integrity_iint_cache *iint = foo;
>
> memset(iint, 0, sizeof(*iint));
> - iint->version = 0;
> - iint->flags = 0UL;
> iint->ima_file_status = INTEGRITY_UNKNOWN;
> iint->ima_mmap_status = INTEGRITY_UNKNOWN;
> iint->ima_bprm_status = INTEGRITY_UNKNOWN;
> iint->ima_read_status = INTEGRITY_UNKNOWN;
> iint->evm_status = INTEGRITY_UNKNOWN;
> - iint->measured_pcrs = 0;
> }
>
> static int __init integrity_iintcache_init(void)
> --
> 2.13.0

\
 
 \ /
  Last update: 2017-07-06 17:05    [W:0.019 / U:17.352 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site