lkml.org 
[lkml]   [2017]   [Jul]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH][drm-next] drm/amdgpu: make arrays pctl0_data and pctl1_data static
    On Thu, Jul 6, 2017 at 5:58 AM, Colin King <colin.king@canonical.com> wrote:
    > From: Colin Ian King <colin.king@canonical.com>
    >
    > The arrays pctl0_data and pctl1_data do not need to be in global scope,
    > so them both static.
    >
    > Cleans up sparse warnings:
    > symbol 'pctl0_data' was not declared. Should it be static?
    > symbol 'pctl1_data' was not declared. Should it be static?
    >
    > Signed-off-by: Colin Ian King <colin.king@canonical.com>


    Applied. thanks!

    Alex

    > ---
    > drivers/gpu/drm/amd/amdgpu/mmhub_v1_0.c | 4 ++--
    > 1 file changed, 2 insertions(+), 2 deletions(-)
    >
    > diff --git a/drivers/gpu/drm/amd/amdgpu/mmhub_v1_0.c b/drivers/gpu/drm/amd/amdgpu/mmhub_v1_0.c
    > index 9804318f3488..4c079207d699 100644
    > --- a/drivers/gpu/drm/amd/amdgpu/mmhub_v1_0.c
    > +++ b/drivers/gpu/drm/amd/amdgpu/mmhub_v1_0.c
    > @@ -249,7 +249,7 @@ struct pctl_data {
    > uint32_t data;
    > };
    >
    > -const struct pctl_data pctl0_data[] = {
    > +static const struct pctl_data pctl0_data[] = {
    > {0x0, 0x7a640},
    > {0x9, 0x2a64a},
    > {0xd, 0x2a680},
    > @@ -274,7 +274,7 @@ const struct pctl_data pctl0_data[] = {
    > #define PCTL0_STCTRL_REG_SAVE_RANGE0_BASE 0xa640
    > #define PCTL0_STCTRL_REG_SAVE_RANGE0_LIMIT 0xa833
    >
    > -const struct pctl_data pctl1_data[] = {
    > +static const struct pctl_data pctl1_data[] = {
    > {0x0, 0x39a000},
    > {0x3b, 0x44a040},
    > {0x81, 0x2a08d},
    > --
    > 2.11.0
    >
    > _______________________________________________
    > dri-devel mailing list
    > dri-devel@lists.freedesktop.org
    > https://lists.freedesktop.org/mailman/listinfo/dri-devel

    \
     
     \ /
      Last update: 2017-07-06 16:17    [W:3.063 / U:1.200 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site