lkml.org 
[lkml]   [2017]   [Jul]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4/4] selftests: ftrace: Output only to console with "--logdir -"
On Wed, Jul 05, 2017 at 12:25:06PM -0400, Steven Rostedt wrote:
> On Tue, 4 Jul 2017 15:38:55 +0900
> Masami Hiramatsu <mhiramat@kernel.org> wrote:
>
> > + local testlog=`mktemp $LOG_DIR/${testname}-log.XXXXXX`
> > + else
> > + local testlog=`/proc/self/fd/1`
>
> cute trick.

Shouldn't this be:

local testlog=/proc/self/fd/1

without the backticks and subshell? We just want to write to the stdout
file not execute it.

Or am missing something.

-Stafford

\
 
 \ /
  Last update: 2017-07-06 15:08    [W:0.060 / U:15.000 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site