lkml.org 
[lkml]   [2017]   [Jul]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] wlcore: add missing nvs file name info for wilink8
* Sebastian Reichel <sebastian.reichel@collabora.co.uk> [170705 01:29]:
> Hi,
>
> On Wed, Jul 05, 2017 at 01:06:54AM -0700, Tony Lindgren wrote:
> > > > Not sure if this really is a regression as we've always had a bogus
> > > > wl1271-nvs.bin in linux-firmware.git. Sure would be nice to fix it,
> > > > but going back to using a generic wl1271-nvs.bin sure does not seem
> > > > like a good long term fix to me :)
> > > A lot of legacy here...
> > > Wl1271-nvs has been used mainly with wilink6/7 and indeed was device specific
> > > Holding calibration info etc.
> > > When they started with wilink8 the device specific configuration that was
> > > Part of it has switched to wl18xx-conf.bin and using the wlaconf tool for setting it.
> > > Also there is no calibration specific info per device with wilink8 so the wl18xx-conf.bin
> > > The only thing left in wl1271-nvs.bin for wilink8 was the mac address override.
> >
> > And the default wl1271-nvs.bin sets the mac address to a bogus deadbeef address,
> > so it's wrong to use and totally broken for distros :(
>
> So use something like the following pseudo-code?
>
> if (fw->mac_address == deadbeef) {
> fw->mac_address = get_random_mac();
> dev_warn(dev, "Detected unconfigured wl1271-nvs.bin.\n"
> "Your device will run with limited performance.\n"
> "Please use ti-utils to configure your device.\n");
> }

Yeah something like that should do the trick :)

Regards,

Tony


\
 
 \ /
  Last update: 2017-07-06 08:27    [W:0.047 / U:13.464 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site