lkml.org 
[lkml]   [2017]   [Jul]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] irqchip/mips-gic: Add missing shared interrupt handler
On Thu, 6 Jul 2017, jrjang@gmail.com wrote:

CC+ MIPS folks. There is a reason WHY I added them to my previous reply.

> From: Jun-Ru Chang <jrjang@gmail.com>
>
> Commit b87281e7f205 ("irqchip/mips-gic: Remove device IRQ domain")
> removes the device IRQ domain and uses gic_irq_domain_alloc() to
> allocate the shared/local domain. However, the shared interrupt handler
> is not set after allocating. It causes that the system hangs with
> "unexpected IRQ" messages disaply.
>
> And commit 8ada00a650ec ("irqchip/mips-gic: Replace static map with
> dynamic") renames gic_irq_domain_alloc() to gic_irq_domain_map() to set
> up the handler and chip. Fix this by setting the handle_level_irq
> handler for shared interrupts.
>
> Fixes: b87281e7f205 ("irqchip/mips-gic: Remove device IRQ domain")
> Signed-off-by: Jun-Ru Chang <jrjang@gmail.com>
> ---
> Change in v2:
> - changed commit message
>
> drivers/irqchip/irq-mips-gic.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/irqchip/irq-mips-gic.c b/drivers/irqchip/irq-mips-gic.c
> index 929f8558bf1c..0a5fb30deb17 100644
> --- a/drivers/irqchip/irq-mips-gic.c
> +++ b/drivers/irqchip/irq-mips-gic.c
> @@ -716,6 +716,7 @@ static int gic_irq_domain_map(struct irq_domain *d, unsigned int virq,
> if (err)
> return err;
>
> + irq_set_handler(virq, handle_level_irq);
> return gic_shared_irq_domain_map(d, virq, hwirq, 0);
> }
>
> --
> 2.13.2
>

\
 
 \ /
  Last update: 2017-07-06 14:05    [W:0.050 / U:34.032 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site