Messages in this thread | | | Date | Wed, 5 Jul 2017 12:29:17 -0400 | From | Steven Rostedt <> | Subject | Re: [PATCH 4/4] selftests: ftrace: Output only to console with "--logdir -" |
| |
On Wed, 5 Jul 2017 12:25:06 -0400 Steven Rostedt <rostedt@goodmis.org> wrote:
> > @@ -255,12 +262,18 @@ __run_test() { # testfile > > # Run one test case > > run_test() { # testfile > > local testname=`basename $1` > > - local testlog=`mktemp $LOG_DIR/${testname}-log.XXXXXX` > > + if [ "$LOG_FILE" ] ; then > > Shouldn't this be > > if [ ! -z "$LOG_FILE" ]; then > > ? >
OK, I just checked it out. I guess "" is considered zero and "<anything>" is considered 1.
Hmm, do we do this in other places too. Just makes me unconfortable.
-- Steve
| |