lkml.org 
[lkml]   [2017]   [Jul]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4/4] selftests: ftrace: Output only to console with "--logdir -"
On Wed, 5 Jul 2017 12:25:06 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:


> > @@ -255,12 +262,18 @@ __run_test() { # testfile
> > # Run one test case
> > run_test() { # testfile
> > local testname=`basename $1`
> > - local testlog=`mktemp $LOG_DIR/${testname}-log.XXXXXX`
> > + if [ "$LOG_FILE" ] ; then
>
> Shouldn't this be
>
> if [ ! -z "$LOG_FILE" ]; then
>
> ?
>

OK, I just checked it out. I guess "" is considered zero and
"<anything>" is considered 1.

Hmm, do we do this in other places too. Just makes me unconfortable.

-- Steve

\
 
 \ /
  Last update: 2017-07-05 18:29    [W:0.074 / U:0.076 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site