Messages in this thread | | | Subject | Re: [PATCH] KVM: vmx: expose more information for KVM_INTERNAL_ERROR_DELIVERY_EV exits | From | Paolo Bonzini <> | Date | Wed, 5 Jul 2017 14:26:15 +0200 |
| |
On 05/07/2017 14:25, David Hildenbrand wrote: >> vcpu->run->internal.suberror = KVM_INTERNAL_ERROR_DELIVERY_EV; >> - vcpu->run->internal.ndata = 2; >> + vcpu->run->internal.ndata = 3; >> vcpu->run->internal.data[0] = vectoring_info; >> vcpu->run->internal.data[1] = exit_reason; >> + vcpu->run->internal.data[2] = vcpu->arch.exit_qualification; >> + if (exit_reason == EXIT_REASON_EPT_MISCONFIG) { >> + vcpu->run->internal.ndata++; >> + vcpu->run->internal.data[3] = >> + vmcs_read64(GUEST_PHYSICAL_ADDRESS); > vcpu->run->internal.data[vcpu->run->internal.ndata++] = ...
I considered that, but it's very long and the initializations above use numbers. Considering that this is not going to change very often, I ended up with the hard coded 3.
Paolo
> So we don't have to name the position explicitly. > > Whatever you prefer. > > Reviewed-by: David Hildenbrand <david@redhat.com> >
| |