Messages in this thread | | | From | David Laight <> | Subject | RE: [PATCH 1/5] Fix packed and aligned attribute warnings. | Date | Mon, 31 Jul 2017 13:27:47 +0000 |
| |
From: SZ Lin > Sent: 29 July 2017 08:24 ... > diff --git a/drivers/char/tpm/tpm_ibmvtpm.h b/drivers/char/tpm/tpm_ibmvtpm.h > index 91dfe766d080..9f708ca3dc84 100644 > --- a/drivers/char/tpm/tpm_ibmvtpm.h > +++ b/drivers/char/tpm/tpm_ibmvtpm.h > @@ -25,7 +25,7 @@ struct ibmvtpm_crq { > __be16 len; > __be32 data; > __be64 reserved; > -} __attribute__((packed, aligned(8))); > +} __packed __aligned(8);
You can't need __packed and __aligned(8) on that structure. There are no gaps and you are saying it is always aligned.
So just remove the pointless attributes.
David
| |