Messages in this thread | | | Date | Mon, 31 Jul 2017 18:01:57 +0530 | From | Vinod Koul <> | Subject | Re: [PATCH v3 2/5] dmaengine: Add STM32 DMAMUX driver |
| |
On Wed, Jul 26, 2017 at 07:38:02AM +0000, Pierre Yves MORDRET wrote: > >>>> + > >>>> +#ifndef __DMA_STM32_DMAMUX_H > >>>> +#define __DMA_STM32_DMAMUX_H > >>>> + > >>>> +#if defined(CONFIG_STM32_DMAMUX) > >>>> +int stm32_dmamux_set_config(struct device *dev, void *route_data, u32 chan_id); > >>> > >>> Why do we need a custom API in this case? > >>> > >> > >> This API is called by DMA when a slave is requested by client. DMA can work > >> without DMAMUX this API has been put in place to configure DMAMUX whether client > >> is requesting a DMAMUX Channel instead of a DMA one. > > > > You mean the dmaengine driver right? > > > > Yes. The API is mainly called by "device_config" through out STM32 DMA Driver > when a router is in place for client. > Please refer to Patch 4/5 on this set.
Okay am thinking on why this can't be generic..? An optional router config callback?
-- ~Vinod
| |