lkml.org 
[lkml]   [2017]   [Jul]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] fbcon: Use background color for margins
From
Date
On 07/30/2017 04:47 AM, Pavel Machek wrote:
> Hi!
>
>> Screens that don't have a black border around the active area will have
>> ugly black bars for the margin when the text background color is not black.
>> This is especially noticeable on an LCD screen (not the backlit kind) when
>> the terminal colors are inverted.
>
> Are you sure?

Of course I am sure. Otherwise I would not send a patch. ;-)

I have attached some pictures to explain it better. The
default-console.jpg picture shows what it looks like using just
defaults. I think it is hard to read the white text with the black
background.

So, the solution is to invert the terminal colors. But when you do this,
the margins are not inverted, so you are left with black bars on the
bottom and the right as seen in inverted-without-patch.jpg.

With this patch applied, the margins are also inverted, so you don't
have the black bars as seen in inverted-with-patch.jpg. I think this is
much nicer.

It is quite common to have different backgrounds in
> different parts of the screen, how it is supposed to work there?

There will be nothing different in this regard. Only the margins
(non-text area) are changed.
[unhandled content-type:image/jpeg][unhandled content-type:image/jpeg][unhandled content-type:image/jpeg]
\
 
 \ /
  Last update: 2017-07-30 21:57    [W:2.631 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site