lkml.org 
[lkml]   [2017]   [Jul]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 1/6] drm/tinydrm: Add parameter for MIPI DCS pixel format
On Sat, Jul 29, 2017 at 10:17 PM, David Lechner <david@lechnology.com> wrote:
> This adds a parameter for MIPI DCS pixel format to mipi_dbi_init().
> This is in preparation for supporting displays that don't use a 16bpp
> memory layout.

> /* MIPI DCS pixel formats */
> -#define MIPI_DCS_PIXEL_FMT_24BIT 7
> -#define MIPI_DCS_PIXEL_FMT_18BIT 6
> -#define MIPI_DCS_PIXEL_FMT_16BIT 5
> -#define MIPI_DCS_PIXEL_FMT_12BIT 3
> -#define MIPI_DCS_PIXEL_FMT_8BIT 2
> -#define MIPI_DCS_PIXEL_FMT_3BIT 1
> +enum mipi_dcs_pixel_format {
> + MIPI_DCS_PIXEL_FMT_24BIT = 7,
> + MIPI_DCS_PIXEL_FMT_18BIT = 6,
> + MIPI_DCS_PIXEL_FMT_16BIT = 5,
> + MIPI_DCS_PIXEL_FMT_12BIT = 3,
> + MIPI_DCS_PIXEL_FMT_8BIT = 2,
> + MIPI_DCS_PIXEL_FMT_3BIT = 1,
> +};

May I ask what prevents us to arrange enums in natural
ordering (you may keep = X parts, of course)?

--
With Best Regards,
Andy Shevchenko

\
 
 \ /
  Last update: 2017-07-30 20:12    [W:0.165 / U:0.560 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site