lkml.org 
[lkml]   [2017]   [Jul]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 087/101] watchdog: bcm281xx: Fix use of uninitialized spinlock.
    Date
    4.4-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Eric Anholt <eric@anholt.net>

    commit fedf266f9955d9a019643cde199a2fd9a0259f6f upstream.

    The bcm_kona_wdt_set_resolution_reg() call takes the spinlock, so
    initialize it earlier. Fixes a warning at boot with lock debugging
    enabled.

    Fixes: 6adb730dc208 ("watchdog: bcm281xx: Watchdog Driver")
    Signed-off-by: Eric Anholt <eric@anholt.net>
    Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
    Reviewed-by: Guenter Roeck <linux@roeck-us.net>
    Signed-off-by: Guenter Roeck <linux@roeck-us.net>
    Signed-off-by: Wim Van Sebroeck <wim@iguana.be>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/watchdog/bcm_kona_wdt.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    --- a/drivers/watchdog/bcm_kona_wdt.c
    +++ b/drivers/watchdog/bcm_kona_wdt.c
    @@ -304,6 +304,8 @@ static int bcm_kona_wdt_probe(struct pla
    if (!wdt)
    return -ENOMEM;

    + spin_lock_init(&wdt->lock);
    +
    res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
    wdt->base = devm_ioremap_resource(dev, res);
    if (IS_ERR(wdt->base))
    @@ -316,7 +318,6 @@ static int bcm_kona_wdt_probe(struct pla
    return ret;
    }

    - spin_lock_init(&wdt->lock);
    platform_set_drvdata(pdev, wdt);
    watchdog_set_drvdata(&bcm_kona_wdt_wdd, wdt);
    bcm_kona_wdt_wdd.parent = &pdev->dev;

    \
     
     \ /
      Last update: 2017-07-03 15:40    [W:3.005 / U:0.284 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site