lkml.org 
[lkml]   [2017]   [Jul]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 014/101] sfc: provide dummy definitions of vswitch functions
    Date
    4.4-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Bert Kenward <bkenward@solarflare.com>


    efx_probe_all() calls efx->type->vswitching_probe during probe. For
    SFC4000 (Falcon) NICs this function is not defined, leading to a BUG
    with the top of the call stack similar to:
    ? efx_pci_probe_main+0x29a/0x830
    efx_pci_probe+0x7d3/0xe70

    vswitching_restore and vswitching_remove also need to be defined.

    Fixed in mainline by:
    commit 5a6681e22c14 ("sfc: separate out SFC4000 ("Falcon") support into new sfc-falcon driver")

    Fixes: 6d8aaaf6f798 ("sfc: create VEB vswitch and vport above default firmware setup")
    Signed-off-by: Bert Kenward <bkenward@solarflare.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/net/ethernet/sfc/falcon.c | 10 ++++++++++
    1 file changed, 10 insertions(+)

    --- a/drivers/net/ethernet/sfc/falcon.c
    +++ b/drivers/net/ethernet/sfc/falcon.c
    @@ -2796,6 +2796,11 @@ const struct efx_nic_type falcon_a1_nic_
    .timer_period_max = 1 << FRF_AB_TC_TIMER_VAL_WIDTH,
    .offload_features = NETIF_F_IP_CSUM,
    .mcdi_max_ver = -1,
    +#ifdef CONFIG_SFC_SRIOV
    + .vswitching_probe = efx_port_dummy_op_int,
    + .vswitching_restore = efx_port_dummy_op_int,
    + .vswitching_remove = efx_port_dummy_op_void,
    +#endif
    };

    const struct efx_nic_type falcon_b0_nic_type = {
    @@ -2897,4 +2902,9 @@ const struct efx_nic_type falcon_b0_nic_
    .offload_features = NETIF_F_IP_CSUM | NETIF_F_RXHASH | NETIF_F_NTUPLE,
    .mcdi_max_ver = -1,
    .max_rx_ip_filters = FR_BZ_RX_FILTER_TBL0_ROWS,
    +#ifdef CONFIG_SFC_SRIOV
    + .vswitching_probe = efx_port_dummy_op_int,
    + .vswitching_restore = efx_port_dummy_op_int,
    + .vswitching_remove = efx_port_dummy_op_void,
    +#endif
    };

    \
     
     \ /
      Last update: 2017-07-03 15:39    [W:4.019 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site