lkml.org 
[lkml]   [2017]   [Jul]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] zram: constify attribute_group structures.
On (07/03/17 11:43), Arvind Yadav wrote:
> attribute_groups are not supposed to change at runtime. All functions
> working with attribute_groups provided by <linux/sysfs.h> work with const
> attribute_group. So mark the non-const structs as const.
>
> File size before:
> text data bss dec hex filename
> 8293 841 4 9138 23b2 drivers/block/zram/zram_drv.o
>
> File size After adding 'const':
> text data bss dec hex filename
> 8357 777 4 9138 23b2 drivers/block/zram/zram_drv.o

sorry, what exactly is the improvement here?
we grew .text bigger, why should we be happy about it?

-ss

\
 
 \ /
  Last update: 2017-07-03 11:01    [W:1.808 / U:0.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site