lkml.org 
[lkml]   [2017]   [Jul]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 12/12] mmc: bcm2835: constify mmc_host_ops structures
    Date
    The mmc_host_ops structure is only stored in the ops field of an
    mmc_host structure, which is declared as const. Thus the mmc_host_ops
    structure itself can be const.

    Done with the help of Coccinelle.

    // <smpl>
    @r disable optional_qualifier@
    identifier i;
    position p;
    @@
    static struct mmc_host_ops i@p = { ... };

    @ok1@
    struct mmc_host *mmc;
    identifier r.i;
    position p;
    @@
    mmc->ops = &i@p

    @bad@
    position p != {r.p,ok1.p};
    identifier r.i;
    struct mmc_host_ops e;
    @@
    e@i@p

    @depends on !bad disable optional_qualifier@
    identifier r.i;
    @@
    static
    +const
    struct mmc_host_ops i = { ... };
    // </smpl>

    Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>

    ---
    drivers/mmc/host/bcm2835.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/mmc/host/bcm2835.c b/drivers/mmc/host/bcm2835.c
    index abba9a2..229dc18 100644
    --- a/drivers/mmc/host/bcm2835.c
    +++ b/drivers/mmc/host/bcm2835.c
    @@ -1252,7 +1252,7 @@ static void bcm2835_set_ios(struct mmc_host *mmc, struct mmc_ios *ios)
    mutex_unlock(&host->mutex);
    }

    -static struct mmc_host_ops bcm2835_ops = {
    +static const struct mmc_host_ops bcm2835_ops = {
    .request = bcm2835_request,
    .set_ios = bcm2835_set_ios,
    .hw_reset = bcm2835_reset,
    \
     
     \ /
      Last update: 2017-07-29 08:26    [W:8.589 / U:0.324 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site