Messages in this thread | | | Date | Fri, 28 Jul 2017 07:07:51 -0700 | Subject | Re: [PATCH] HID: wacom: add USB_HID dependency | From | Jason Gerecke <> |
| |
On July 28, 2017 6:18:00 AM PDT, Arnd Bergmann <arnd@arndb.de> wrote: >The driver has gained a compile-time dependency that we should >express in Kconfig to avoid this link error: >
Would conditional compilation be an acceptable alternative to adding a dependency? The USB_HID code is only used to check if the driver is working with a USB device. With USB_HID disabled, there's no need for the check so there's no need for the dependency.
>drivers/hid/wacom_sys.o: In function `wacom_parse_and_register': >wacom_sys.c:(.text+0x2eec): undefined reference to `usb_hid_driver' > >Fixes: 09dc28acaec7 ("HID: wacom: Improve generic name generation") >Signed-off-by: Arnd Bergmann <arnd@arndb.de> >--- > drivers/hid/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig >index 3cd60f460b61..0a3117cc29e7 100644 >--- a/drivers/hid/Kconfig >+++ b/drivers/hid/Kconfig >@@ -924,7 +924,7 @@ config HID_UDRAW_PS3 > > config HID_WACOM > tristate "Wacom Intuos/Graphire tablet support (USB)" >- depends on HID >+ depends on USB_HID > select POWER_SUPPLY > select NEW_LEDS > select LEDS_CLASS
-- Sent from my Android device with K-9 Mail. Please excuse my brevity.
| |