Messages in this thread | | | From | Ulf Hansson <> | Date | Thu, 27 Jul 2017 16:48:32 +0200 | Subject | Re: [PATCH] mmc: host: via-sdmmc: constify pci_device_id. |
| |
On 17 July 2017 at 18:31, Arvind Yadav <arvind.yadav.cs@gmail.com> wrote: > pci_device_id are not supposed to change at runtime. All functions > working with pci_device_id provided by <linux/pci.h> work with > const pci_device_id. So mark the non-const structs as const. > > File size before: > text data bss dec hex filename > 6952 880 0 7832 1e98 drivers/mmc/host/via-sdmmc.o > > File size After adding 'const': > text data bss dec hex filename > 7032 800 0 7832 1e98 drivers/mmc/host/via-sdmmc.o > > Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Thanks, applied for next!
Kind regards Uffe
> --- > drivers/mmc/host/via-sdmmc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/via-sdmmc.c b/drivers/mmc/host/via-sdmmc.c > index 6380044..a838bf5 100644 > --- a/drivers/mmc/host/via-sdmmc.c > +++ b/drivers/mmc/host/via-sdmmc.c > @@ -323,7 +323,7 @@ struct via_crdr_mmc_host { > /* some devices need a very long delay for power to stabilize */ > #define VIA_CRDR_QUIRK_300MS_PWRDELAY 0x0001 > > -static struct pci_device_id via_ids[] = { > +static const struct pci_device_id via_ids[] = { > {PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_9530, > PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0,}, > {0,} > -- > 2.7.4 >
| |