lkml.org 
[lkml]   [2017]   [Jul]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v2 2/5] PCI: mediatek: switch to use platform_get_resource_byname()
    Date
    From: Ryder Lee <ryder.lee@mediatek.com>

    This is a transitional patch. We currently use platfarm_get_resource() for
    retrieving the IOMEM resources, but there might be some chips don't have
    subsys/shared registers part, which depends on platform design, and these
    will be introduced in further patches.

    Switch this function to use the platform_get_resource_byname() so that the
    binding can be agnostic of the resource order.

    Signed-off-by: Ryder Lee <ryder.lee@mediatek.com>
    ---
    drivers/pci/host/pcie-mediatek.c | 17 ++++++++++-------
    1 file changed, 10 insertions(+), 7 deletions(-)

    diff --git a/drivers/pci/host/pcie-mediatek.c b/drivers/pci/host/pcie-mediatek.c
    index 7f952a4..f8e2f68 100644
    --- a/drivers/pci/host/pcie-mediatek.c
    +++ b/drivers/pci/host/pcie-mediatek.c
    @@ -295,7 +295,8 @@ static int mtk_pcie_parse_ports(struct mtk_pcie *pcie,
    return err;
    }

    - regs = platform_get_resource(pdev, IORESOURCE_MEM, index + 1);
    + snprintf(name, sizeof(name), "port%d", index);
    + regs = platform_get_resource_byname(pdev, IORESOURCE_MEM, name);
    port->base = devm_ioremap_resource(dev, regs);
    if (IS_ERR(port->base)) {
    dev_err(dev, "failed to map port%d base\n", index);
    @@ -336,12 +337,14 @@ static int mtk_pcie_subsys_powerup(struct mtk_pcie *pcie)
    struct resource *regs;
    int err;

    - /* get shared registers */
    - regs = platform_get_resource(pdev, IORESOURCE_MEM, 0);
    - pcie->base = devm_ioremap_resource(dev, regs);
    - if (IS_ERR(pcie->base)) {
    - dev_err(dev, "failed to map shared register\n");
    - return PTR_ERR(pcie->base);
    + /* get shared registers, which are optional */
    + regs = platform_get_resource_byname(pdev, IORESOURCE_MEM, "subsys");
    + if (regs) {
    + pcie->base = devm_ioremap_resource(dev, regs);
    + if (IS_ERR(pcie->base)) {
    + dev_err(dev, "failed to map shared register\n");
    + return PTR_ERR(pcie->base);
    + }
    }

    pcie->free_ck = devm_clk_get(dev, "free_ck");
    --
    2.6.4
    \
     
     \ /
      Last update: 2017-07-27 04:59    [W:4.225 / U:0.048 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site