Messages in this thread | | | Date | Wed, 26 Jul 2017 11:32:44 +0300 | From | Mika Westerberg <> | Subject | Re: [RFC][PATCH] thunderbolt: icm: Ignore mailbox errors in icm_suspend() |
| |
On Tue, Jul 25, 2017 at 06:10:57PM +0200, Rafael J. Wysocki wrote: > On Tuesday, July 25, 2017 01:00:12 PM Mika Westerberg wrote: > > On Tue, Jul 25, 2017 at 01:31:00AM +0200, Rafael J. Wysocki wrote: > > > From: Rafael J. Wysocki <rafael.j.wysocki@intel.com> > > > > > > On one of my test machines nhi_mailbox_cmd() called from icm_suspend() > > > times out and returnes an error which then is propagated to the > > > caller and causes the entire system suspend to be aborted which isn't > > > very useful. > > > > > > Instead of aborting system suspend, print the error into the log > > > and continue. > > > > I agree, it should not prevent suspend but I wonder why it fails in the > > first place? Can you check what is the return value? > > As per the above, the error is a timeout, ie. -ETIMEDOUT.
Ah, right I somehow missed that.
Does it have Falcon Ridge controller or Alpine Ridge? Just to make sure, can you increase the timeout in nhi_mailbox_cmd() to 1000ms or so. It should not take that long though but better to check.
Which system this is BTW?
| |