lkml.org 
[lkml]   [2017]   [Jul]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 01/11] ASoC: samsung: s3c2412: Handle return value of clk_prepare_enable.
    On Tue, Jul 25, 2017 at 03:44:28PM +0530, Arvind Yadav wrote:
    > clk_prepare_enable() can fail here and we must check its return value.
    >
    > Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
    > ---
    > sound/soc/samsung/s3c2412-i2s.c | 4 +++-
    > 1 file changed, 3 insertions(+), 1 deletion(-)
    >
    > diff --git a/sound/soc/samsung/s3c2412-i2s.c b/sound/soc/samsung/s3c2412-i2s.c
    > index 0a47182..bcd1cbd 100644
    > --- a/sound/soc/samsung/s3c2412-i2s.c
    > +++ b/sound/soc/samsung/s3c2412-i2s.c
    > @@ -71,7 +71,9 @@ static int s3c2412_i2s_probe(struct snd_soc_dai *dai)
    > /* Set MPLL as the source for IIS CLK */
    >
    > clk_set_parent(s3c2412_i2s.iis_cclk, clk_get(NULL, "mpll"));
    > - clk_prepare_enable(s3c2412_i2s.iis_cclk);
    > + ret = clk_prepare_enable(s3c2412_i2s.iis_cclk);
    > + if (ret)

    You miss here path for error handling for things done in
    s3c_i2sv2_probe().

    Best regards,
    Krzysztof

    > + return ret;
    >
    > s3c2412_i2s.iis_cclk = s3c2412_i2s.iis_pclk;
    >
    > --
    > 1.9.1
    >

    \
     
     \ /
      Last update: 2017-07-25 19:44    [W:4.142 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site