lkml.org 
[lkml]   [2017]   [Jul]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v1] pwm: pca9685: clarify pca9685_set_sleep_mode() interface.
    On Fri, Apr 21, 2017 at 09:19:02AM -0400, Sven Van Asbroeck wrote:
    > The function
    > static void pca9685_set_sleep_mode(struct pca9685 *pca, int sleep)
    > takes the chip in and out of sleep mode, depending on the value of
    > sleep, which is interpreted as a boolean.
    >
    > To clarify that 'int sleep' is a boolean and not a sleep delay,
    > change the function interface to:
    > static void pca9685_set_sleep_mode(struct pca9685 *pca, bool enable)
    >
    > Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
    > Signed-off-by: Sven Van Asbroeck <thesven73@gmail.com>
    > ---
    > drivers/pwm/pwm-pca9685.c | 14 +++++++-------
    > 1 file changed, 7 insertions(+), 7 deletions(-)

    Applied, thanks.

    Thierry
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2017-07-25 13:43    [W:3.143 / U:1.580 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site