Messages in this thread | | | Date | Tue, 25 Jul 2017 13:42:17 +0200 | From | Thierry Reding <> | Subject | Re: [PATCH v1] pwm: pca9685: clarify pca9685_set_sleep_mode() interface. |
| |
On Fri, Apr 21, 2017 at 09:19:02AM -0400, Sven Van Asbroeck wrote: > The function > static void pca9685_set_sleep_mode(struct pca9685 *pca, int sleep) > takes the chip in and out of sleep mode, depending on the value of > sleep, which is interpreted as a boolean. > > To clarify that 'int sleep' is a boolean and not a sleep delay, > change the function interface to: > static void pca9685_set_sleep_mode(struct pca9685 *pca, bool enable) > > Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > Signed-off-by: Sven Van Asbroeck <thesven73@gmail.com> > --- > drivers/pwm/pwm-pca9685.c | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-)
Applied, thanks.
Thierry [unhandled content-type:application/pgp-signature] | |