Messages in this thread | | | Subject | Re: [PATCH v2] mm: Drop useless local parameters of __register_one_node() | From | Dou Liyang <> | Date | Tue, 25 Jul 2017 19:15:42 +0800 |
| |
Hi Michael,
At 07/25/2017 05:09 PM, Michael Ellerman wrote: > Dou Liyang <douly.fnst@cn.fujitsu.com> writes: > >> ... initializes local parameters "p_node" & "parent" for >> register_node(). >> >> But, register_node() does not use them. >> >> Remove the related code of "parent" node, cleanup __register_one_node() >> and register_node(). >> >> Cc: Andrew Morton <akpm@linux-foundation.org> >> Cc: David Rientjes <rientjes@google.com> >> Cc: Michal Hocko <mhocko@kernel.org> >> Cc: isimatu.yasuaki@jp.fujitsu.com >> Signed-off-by: Dou Liyang <douly.fnst@cn.fujitsu.com> >> Acked-by: David Rientjes <rientjes@google.com> >> --- >> V1 --> V2: >> Rebase it on >> git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git akpm >> >> drivers/base/node.c | 9 ++------- >> 1 file changed, 2 insertions(+), 7 deletions(-) > > That appears to be the last user of parent_node().
Oops, yes, it is the last one.
> > Can we start removing it from the topology.h headers for each arch? >
Yes, I think so.
Thanks, dou.
> cheers > > >
| |