lkml.org 
[lkml]   [2017]   [Jul]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 49/83] ipmi:ssif: Add missing unlock in error branch
    Date
    4.4-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Corey Minyard <cminyard@mvista.com>

    commit 4495ec6d770e1bca7a04e93ac453ab6720c56c5d upstream.

    When getting flags, a response to a different message would
    result in a deadlock because of a missing unlock. Add that
    unlock and a comment. Found by static analysis.

    Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
    Signed-off-by: Corey Minyard <cminyard@mvista.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/char/ipmi/ipmi_ssif.c | 5 +++++
    1 file changed, 5 insertions(+)

    --- a/drivers/char/ipmi/ipmi_ssif.c
    +++ b/drivers/char/ipmi/ipmi_ssif.c
    @@ -758,6 +758,11 @@ static void msg_done_handler(struct ssif
    result, len, data[2]);
    } else if (data[0] != (IPMI_NETFN_APP_REQUEST | 1) << 2
    || data[1] != IPMI_GET_MSG_FLAGS_CMD) {
    + /*
    + * Don't abort here, maybe it was a queued
    + * response to a previous command.
    + */
    + ipmi_ssif_unlock_cond(ssif_info, flags);
    pr_warn(PFX "Invalid response getting flags: %x %x\n",
    data[0], data[1]);
    } else {

    \
     
     \ /
      Last update: 2017-07-25 23:00    [W:2.519 / U:0.112 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site