Messages in this thread | | | Date | Mon, 24 Jul 2017 09:59:14 +0200 (CEST) | From | Marcus Wolf <> | Subject | Re: [PATCH 1/3] staging: pi433: Style fix - align block comments |
| |
Hi Dan,
when I started with the RFM69CW about two years ago (at the beginning not as a driver, but everything within the applicaton) I kind of automatically produced a list of all registers of the chip (most probably by importing and reorganizing the datasheet in Excel). Everytime I need to touch a register, I started to crosscheck the names and masks and took them out of comment.
All registers, I did not touch the last two years are from this autogeneration and commented. There is stil a lot of functionality of the chip, that's not supported (or not needed) by the driver.
Cheers,
Marcus > Dan Carpenter <dan.carpenter@oracle.com> hat am 24. Juli 2017 um 09:41 > geschrieben: > > > On Sat, Jul 22, 2017 at 03:50:50PM +1200, Derek Robson wrote: > > + * // RegOsc1 > > + * #define OSC1_RCCAL_START 0x80 > > + * #define OSC1_RCCAL_DONE 0x40 > > + * > > Why do we have all these commented out defines? > > regards, > dan carpenter > >
| |