Messages in this thread | | | Date | Mon, 24 Jul 2017 18:44:00 +0200 | From | Borislav Petkov <> | Subject | Re: [PATCH 3/3] ghes_edac: add platform check to enable ghes_edac |
| |
On Mon, Jul 24, 2017 at 01:04:13PM -0300, Mauro Carvalho Chehab wrote: > If the Kernel force those users to use ghes_edac by default, > they they won't see the error counts anymore, but, instead, > hardware reports that the memories need to be replaced.
This is exactly why I'm trying to load ghes_edac only on those platforms which would really want it.
> So, the right solution would be to keep hardware first, but > providing a modprobe parameter to let them switch to software > first.
That's exactly the issue: if we make it spec-conform and adhere to FF setting, then it'll be clean. BUT(!), we will force ghes_edac on those platforms which potentially are using the platform-specific drivers until now. Not good.
If we do the whitelisting, then we're stuck with maintaining a yucky whitelist and have to keep updating ghes_edac with it.
So we're basically between a rock and a hard place.
If I had to choose *right* *now*, I'd probably lean slightly towards the whitelist as it won't break existing users.
A big grumpfy-grumbly hmmm. :-\
-- Regards/Gruss, Boris.
ECO tip #101: Trim your mails when you reply. --
| |