lkml.org 
[lkml]   [2017]   [Jul]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] PCI: xilinx: Remove platform/architecture restrictions
Date
Hi Guenter & all,

On Monday, 24 July 2017 01:39:37 BST Guenter Roeck wrote:
> The MIPS Boston board configuration tries to enable CONFIG_PCIE_XILINX.
> That doesn't work since PCIE_XILINX depends on ARCH_ZYNQ || MICROBLAZE.
> Remove that restriction.

I'd prefer that this patch does not go in standalone. The intent for the MIPS
Boston board is that this driver is enabled for MIPS by this patch:

https://patchwork.kernel.org/patch/9794361/

But not until after earlier patches in that series fix issues with the driver:

https://patchwork.kernel.org/patch/9794355/
https://patchwork.kernel.org/patch/9794357/
https://patchwork.kernel.org/patch/9794359/

That has been held up by disagreement about whether the driver should be using
0-3 or 1-4 for hardware IRQ numbers, sadly, despite the driver already being
in tree & clearly broken, and my series not changing which the driver uses...

In any case, I don't really mind if people would rather remove the
architecture restrictions than just add MIPS, but I'd prefer this doesn't go
in until the rest of my series since without at least patch 1 of my seres this
will lead to various WARN()s on Boston boards.

Thanks,
Paul

>
> Cc: Paul Burton <paul.burton@imgtec.com>
> Cc: James Hogan <james.hogan@imgtec.com>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/pci/host/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/pci/host/Kconfig b/drivers/pci/host/Kconfig
> index 89d61c2cbfaa..ed905a5401c3 100644
> --- a/drivers/pci/host/Kconfig
> +++ b/drivers/pci/host/Kconfig
> @@ -71,7 +71,6 @@ config PCI_HOST_GENERIC
>
> config PCIE_XILINX
> bool "Xilinx AXI PCIe host bridge support"
> - depends on ARCH_ZYNQ || MICROBLAZE
> help
> Say 'Y' here if you want kernel to support the Xilinx AXI PCIe
> Host Bridge driver.

[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2017-07-24 12:50    [W:5.710 / U:0.100 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site