Messages in this thread | | | Date | Sun, 23 Jul 2017 14:54:14 +0200 | From | Johan Hovold <> | Subject | Re: [PATCH] Staging: greybus: Match alignment with open parenthesis. |
| |
On Sun, Jul 23, 2017 at 03:10:53PM +0300, Dan Carpenter wrote: > On Sun, Jul 23, 2017 at 10:47:43AM +0200, Johan Hovold wrote: > > On Sun, Jul 23, 2017 at 02:09:57PM +0530, Shreeya Patel wrote: > > > Alignment should match with open parenthesis. > > > This fixes the coding style issue. > > > > No, it need not. This is a choice left up to the author, even if > > checkpatch happens to complain about it with the --strict option. > > > > This is staging code. Don't try to fight checkpatch.pl in staging... > You're just making work for everyone else (me) who already just reviewed > this patch and I don't want to review it a few more times when the next > person sends the exact same patch.
You can just ignore any greybus patches if you prefer.
I've considered patching checkpatch to drop --strict for at least this subsystem, but not sure it's worth it.
Johan
| |