Messages in this thread | | | Date | Sun, 23 Jul 2017 10:26:01 -0700 | From | Stephen Hemminger <> | Subject | Re: [PATCH V4 net-next 7/8] net: hns3: Add Ethtool support to HNS3 driver |
| |
On Sat, 22 Jul 2017 23:09:41 +0100 Salil Mehta <salil.mehta@huawei.com> wrote:
> + HNS3_NETDEV_STAT("rx_packets", rx_packets), > + HNS3_NETDEV_STAT("tx_packets", tx_packets), > + HNS3_NETDEV_STAT("rx_bytes", rx_bytes), > + HNS3_NETDEV_STAT("tx_bytes", tx_bytes), > + HNS3_NETDEV_STAT("rx_errors", rx_errors), > + HNS3_NETDEV_STAT("tx_errors", tx_errors), > + HNS3_NETDEV_STAT("rx_dropped", rx_dropped), > + HNS3_NETDEV_STAT("tx_dropped", tx_dropped), > + HNS3_NETDEV_STAT("multicast", multicast), > + HNS3_NETDEV_STAT("collisions", collisions), > + > + /* detailed Rx errors */
Do not put network statistics in ethtool statistics. This is redundant and unnecessary. Yes some other drivers may do it but it is not best practice.
| |