lkml.org 
[lkml]   [2017]   [Jul]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: [PATCH v3 0/4] Add xxhash and zstd modules
    On Fri, Jul 21, 2017 at 11:56:21AM -0400, Austin S. Hemmelgarn wrote:
    > On 2017-07-20 17:27, Nick Terrell wrote:
    > > This patch set adds xxhash, zstd compression, and zstd decompression
    > > modules. It also adds zstd support to BtrFS and SquashFS.
    > >
    > > Each patch has relevant summaries, benchmarks, and tests.
    >
    > For patches 2-3, I've compile tested and had runtime testing running for
    > about 18 hours now with no issues, so you can add:
    >
    > Tested-by: Austin S. Hemmelgarn <ahferroin7@gmail.com>

    I assume you haven't tried it on arm64, right?

    I had no time to get 'round to it before, and just got the following build
    failure:

    CC fs/btrfs/zstd.o
    In file included from fs/btrfs/zstd.c:28:0:
    fs/btrfs/compression.h:39:2: error: unknown type name ‘refcount_t’
    refcount_t pending_bios;
    ^~~~~~~~~~
    scripts/Makefile.build:302: recipe for target 'fs/btrfs/zstd.o' failed

    It's trivially fixably by:
    --- a/fs/btrfs/zstd.c
    +++ b/fs/btrfs/zstd.c
    @@ -24,6 +24,7 @@
    #include <linux/sched.h>
    #include <linux/pagemap.h>
    #include <linux/bio.h>
    +#include <linux/refcount.h>
    #include <linux/zstd.h>
    #include "compression.h"

    after which it works fine, although half an hour of testing isn't exactly
    exhaustive.

    Alas, the armhf machine I ran stress tests (Debian archive rebuilds) on
    doesn't boot with 4.13-rc1 due to some unrelated regression, bisecting that
    would be quite painful so I did not try yet. I guess re-testing your patch
    set on 4.12, even with btrfs-for-4.13 (which it had for a while), wouldn't
    be of much help. So far, previous versions have been running for weeks,
    with no issue since you fixed workspace flickering.


    On amd64 all is fine.


    I haven't tested SquashFS at all.


    Meow!
    --
    ⢀⣴⠾⠻⢶⣦⠀
    ⣾⠁⢠⠒⠀⣿⡁ A dumb species has no way to open a tuna can.
    ⢿⡄⠘⠷⠚⠋⠀ A smart species invents a can opener.
    ⠈⠳⣄⠀⠀⠀⠀ A master species delegates.

    \
     
     \ /
      Last update: 2017-07-22 13:36    [W:2.262 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site