Messages in this thread Patch in this message | | | From | Yingjoe Chen <> | Subject | [PATCH] checkpatch: testing more config for Kconfig help text | Date | Fri, 21 Jul 2017 19:03:37 +0800 |
| |
Current help text check only check a config option if it is followed by another config. Adding check for help text if the next entry is menuconfig, choice/ endchoice, comment, menu/endmenu, if/endif, source or end of file.
Change-Id: I9f0b29cebb93df2cadaf77d1027208fd01efd976 Signed-off-by: Yingjoe Chen <yingjoe.chen@mediatek.com> --- Hi,
This was sent in Jun 2016[1]. I think we should check every configs for help text.
Please let me know if there's anything need to change. Thanks
Joe.C
[1] https://lkml.org/lkml/2016/6/24/360
--- scripts/checkpatch.pl | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 2287a0b..f778702 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -2778,6 +2778,12 @@ sub process { next if ($f =~ /^-/); last if (!$file && $f =~ /^\@\@/); + if ($f !~ /^[+\- ]/) { + # End of file + $is_end = 1; + last; + } + if ($lines[$ln - 1] =~ /^\+\s*(?:bool|tristate)\s*\"/) { $is_start = 1; } elsif ($lines[$ln - 1] =~ /^\+\s*(?:---)?help(?:---)?$/) { @@ -2788,7 +2794,7 @@ sub process { $f =~ s/#.*//; $f =~ s/^\s+//; next if ($f =~ /^$/); - if ($f =~ /^\s*config\s/) { + if ($f =~ /^(?:config\s|menuconfig\s|choice\s|endchoice\s*$|comment\s|menu\s|endmenu\s*$|if\s|endif\s*$|source\s)/) { $is_end = 1; last; } -- 1.7.9.5
| |