lkml.org 
[lkml]   [2017]   [Jul]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC PATCH v1 00/11] Create fast idle path for short idle periods
    On Thu, Jul 20, 2017 at 05:50:54AM -0700, Paul E. McKenney wrote:
    > >
    > > static void cpuidle_idle_call()
    > > {
    > > rcu_idle_enter()
    > > ......
    > > rcu_idle_exit()
    > > }
    > >
    > > I want
    > >
    > > static void cpuidle_idle_call()
    > > {
    > > if (tick stopped)
    > > rcu_idle_enter()
    > > ......
    > > if (tick stopped)
    > > rcu_idle_exit()
    > > }
    > >
    > > Or checking tick stop can be put into rcu_idle_enter/exit
    >
    > The answer is the traditional "it depends".
    >
    > If the above change was all that you did, that would be a bug in the
    > case where the predicted short idle time turned out to in reality be an
    > indefinite idle time.

    Can't be, you didn't disable the tick after all, so you're guaranteed to
    get interrupted by the tick and try again.


    \
     
     \ /
      Last update: 2017-07-20 23:22    [W:4.116 / U:0.140 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site