Messages in this thread Patch in this message | | | Date | Thu, 20 Jul 2017 01:51:11 -0700 | From | tip-bot for Jiri Olsa <> | Subject | [tip:perf/core] perf tests attr: Do not store failed events |
| |
Commit-ID: d78ada4a767a744cad5efa210b8acf57748b91d7 Gitweb: http://git.kernel.org/tip/d78ada4a767a744cad5efa210b8acf57748b91d7 Author: Jiri Olsa <jolsa@kernel.org> AuthorDate: Mon, 3 Jul 2017 16:50:17 +0200 Committer: Arnaldo Carvalho de Melo <acme@redhat.com> CommitDate: Tue, 18 Jul 2017 23:14:14 -0300
perf tests attr: Do not store failed events
Do not mess up our temp space with files we don't need - failed event open attempts.
Signed-off-by: Jiri Olsa <jolsa@kernel.org> Cc: David Ahern <dsahern@gmail.com> Cc: Namhyung Kim <namhyung@kernel.org> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl> Cc: Thomas Richter <tmricht@linux.vnet.ibm.com> Link: http://lkml.kernel.org/r/20170703145030.12903-3-jolsa@kernel.org Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> --- tools/perf/tests/attr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/tests/attr.c b/tools/perf/tests/attr.c index 0e77b2c..08b1d5c 100644 --- a/tools/perf/tests/attr.c +++ b/tools/perf/tests/attr.c @@ -136,7 +136,7 @@ void test_attr__open(struct perf_event_attr *attr, pid_t pid, int cpu, { int errno_saved = errno; - if (store_event(attr, pid, cpu, fd, group_fd, flags)) { + if ((fd != -1) && store_event(attr, pid, cpu, fd, group_fd, flags)) { pr_err("test attr FAILED"); exit(128); }
| |