lkml.org 
[lkml]   [2017]   [Jul]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 7/7] x86: microcode: constify attribute_group structures.
On Thu, Jul 20, 2017 at 01:48:17PM +0530, Arvind Yadav wrote:
> It's just show, how much bytes move from data segment to text segment.
> ~arvind

3614 545 1560 5719 1657 x86/kernel/cpu/microcode/core.o

3614 + 545 = 4159

3742 417 1560 5719 1657 x86/kernel/cpu/microcode/core.o

3742 + 417 = 4159

3742 - 3614 = 128

So 128 bytes moved to text.

I fail to see how this is relevant. Your commit message contains not
really relevant info for such a simple change. Rather, it should just be
a one-liner:

"Constify attribute_group structs because they don't change at runtime."

That's it.

--
Regards/Gruss,
Boris.

ECO tip #101: Trim your mails when you reply.
--

\
 
 \ /
  Last update: 2017-07-20 23:19    [W:0.069 / U:0.588 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site