Messages in this thread | | | Date | Sun, 2 Jul 2017 20:07:23 +0200 (CEST) | From | Thomas Gleixner <> | Subject | Re: [PATCH v5 05/12] x86/apic: Unify interrupt mode setup for SMP-capable system |
| |
On Fri, 30 Jun 2017, Dou Liyang wrote: > -static int __init apic_intr_mode_select(void) > +static int __init apic_intr_mode_select(int *upmode) > { > /* Check kernel option */ > if (disable_apic) { > @@ -1206,12 +1208,30 @@ static int __init apic_intr_mode_select(void) > if (!smp_found_config) { > disable_ioapic_support(); > > - if (!acpi_lapic) > + if (!acpi_lapic) { > pr_info("APIC: ACPI MADT or MP tables are not detected\n"); > + *upmode = true;
That store and extra argument is pointless.
> + > + return APIC_VIRTUAL_WIRE_NO_CONFIG;
You added an extra return code, which you can use exactly for that purpose at the callsite.
Aside of that, if you use int * then use numbers, if you use bool then use true/false. But mixing that is horrible.
> + }
Thanks,
tglx
| |