lkml.org 
[lkml]   [2017]   [Jul]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 42/86] perf test sdt: Handle realpath() failure
    Date
    From: Arnaldo Carvalho de Melo <acme@redhat.com>

    It can return NULL, in which case we should bail out and remove the
    directory created with mkdtemp(), which is stored in the "__tempdir"
    variable, not in "tempdir".

    Cc: Masami Hiramatsu <mhiramat@kernel.org>
    Fixes: 8e5dc848356e ("perf test: Add a test case for SDT event")
    Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
    ---
    tools/perf/tests/sdt.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    diff --git a/tools/perf/tests/sdt.c b/tools/perf/tests/sdt.c
    index 5abe8cea54e6..d80171526f6f 100644
    --- a/tools/perf/tests/sdt.c
    +++ b/tools/perf/tests/sdt.c
    @@ -83,6 +83,8 @@ int test__sdt_event(int subtests __maybe_unused)
    }
    /* Note that buildid_dir must be an absolute path */
    tempdir = realpath(__tempdir, NULL);
    + if (tempdir == NULL)
    + goto error_rmdir;

    /* At first, scan itself */
    set_buildid_dir(tempdir);
    @@ -100,7 +102,7 @@ int test__sdt_event(int subtests __maybe_unused)

    error_rmdir:
    /* Cleanup temporary buildid dir */
    - rm_rf(tempdir);
    + rm_rf(__tempdir);
    error:
    free(tempdir);
    free(myself);
    --
    2.9.4
    \
     
     \ /
      Last update: 2017-07-19 16:48    [W:4.181 / U:0.124 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site