Messages in this thread Patch in this message | | | Date | Tue, 18 Jul 2017 13:07:20 -0700 | From | tip-bot for Julia Lawall <> | Subject | [tip:irq/urgent] irqchip/mips-cpu: Drop unnecessary static |
| |
Commit-ID: 82faeffa7e130e2ae43aa681a34c02d56dabd177 Gitweb: http://git.kernel.org/tip/82faeffa7e130e2ae43aa681a34c02d56dabd177 Author: Julia Lawall <Julia.Lawall@lip6.fr> AuthorDate: Sat, 15 Jul 2017 22:07:41 +0200 Committer: Thomas Gleixner <tglx@linutronix.de> CommitDate: Tue, 18 Jul 2017 21:59:22 +0200
irqchip/mips-cpu: Drop unnecessary static
Drop static on a local variable, when the variable is initialized before any possible use. Thus, the static has no benefit.
The semantic patch that fixes this problem is as follows: (http://coccinelle.lip6.fr/)
// <smpl> @bad exists@ position p; identifier x; type T; @@ static T x@p; ... x = <+...x...+>
@@ identifier x; expression e; type T; position p != bad.p; @@ -static T x@p; ... when != x when strict ?x = e; // </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Cc: Marc Zyngier <marc.zyngier@arm.com> Cc: kernel-janitors@vger.kernel.org Cc: keescook@chromium.org Cc: Jason Cooper <jason@lakedaemon.net> Link: http://lkml.kernel.org/r/1500149266-32357-7-git-send-email-Julia.Lawall@lip6.fr
--- drivers/irqchip/irq-mips-cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/irqchip/irq-mips-cpu.c b/drivers/irqchip/irq-mips-cpu.c index 0a8ed1c..14461cb 100644 --- a/drivers/irqchip/irq-mips-cpu.c +++ b/drivers/irqchip/irq-mips-cpu.c @@ -154,7 +154,7 @@ asmlinkage void __weak plat_irq_dispatch(void) static int mips_cpu_intc_map(struct irq_domain *d, unsigned int irq, irq_hw_number_t hw) { - static struct irq_chip *chip; + struct irq_chip *chip; if (hw < 2 && cpu_has_mipsmt) { /* Software interrupts are used for MT/CMT IPI */
| |