lkml.org 
[lkml]   [2017]   [Jul]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 1/7] ALSA: als100: fix format string overflow warning
On Tue, 18 Jul 2017 13:48:04 +0200,
Arnd Bergmann wrote:
>
> The compiler sees that the format string might overflow for the longname:
>
> sound/isa/als100.c: In function 'snd_als100_pnp_detect':
> sound/isa/als100.c:225:27: error: ', dma ' directive writing 6 bytes into a region of size between 0 and 64 [-Werror=format-overflow=]
> sprintf(card->longname, "%s, %s at 0x%lx, irq %d, dma %d",
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> sound/isa/als100.c:225:3: note: 'sprintf' output between 24 and 113 bytes into a destination of size 80
> sprintf(card->longname, "%s, %s at 0x%lx, irq %d, dma %d",
>
> Open-coding "shortname" here gets us below the limit, and using
> snprintf() is a good idea too.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Thanks, applied all 7 patches now to for-next branch.


Takashi

\
 
 \ /
  Last update: 2017-07-18 18:00    [W:0.050 / U:0.812 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site