lkml.org 
[lkml]   [2017]   [Jul]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 3/9] regulator: mt6380: Add support for MT6380
On Tue, Jul 18, 2017 at 05:49:23PM +0800, sean.wang@mediatek.com wrote:

> + if (!info->modeset_mask) {
> + dev_err(&rdev->dev, "regulator %s doesn't support set_mode\n",
> + info->desc.name);
> + return -EINVAL;
> + }

This is mostly fine but the mode operations all have this code - if the
regulator doesn't have modesetting facilities it just shouldn't have
the ops so the core can handle things in a standard fashion. It'd mean
defining a separate set of operations for those regulators but that's
fine.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2017-07-18 15:32    [W:0.167 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site