Messages in this thread | | | From | Arnd Bergmann <> | Date | Tue, 18 Jul 2017 11:16:10 +0200 | Subject | Re: [RFC PATCH v12 1/4] crypto: make Jitter RNG directly accessible |
| |
On Tue, Jul 18, 2017 at 11:10 AM, Stephan Müller <smueller@chronox.de> wrote: > Am Dienstag, 18. Juli 2017, 11:02:02 CEST schrieb Arnd Bergmann: > > Hi Arnd, >> >> I can see why the jitterentropy implementation avoids using kernel headers, >> the problem now is that part of it gets moved into a new header, and that >> already violates the original principle. >> >> From my reading of the code, we could probably leave the structure >> definition in the crypto/jitterentropy.c, and have the statically >> allocated instance in the same file when CONFIG_LRNG is >> set, > > That is a very good idea -- I will implement this approach.
I guess ideally you just move the inner half of lrng_get_jent(), i.e. everything inside of the spinlock, plus the buffer, into that file. That should keep the low-level side separate from the caller.
Arnd
| |