lkml.org 
[lkml]   [2017]   [Jul]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 2/2] staging: atomisp2: hmm: Alignment code (rebased)
On Thu, Jul 13, 2017 at 09:26:50PM +0200, Philipp wrote:
>
> > On 13. Jul 2017, at 17:45, Sakari Ailus <sakari.ailus@iki.fi> wrote:
> >
> > On Thu, Jul 13, 2017 at 08:55:43AM +0200, Philipp Guendisch wrote:
> >> This patch fixed code alignment to open paranthesis.
> >> Semantic should not be affected by this patch.
> >>
> >> It has been rebased on top of media_tree atomisp branch
> >>
> >> Signed-off-by: Philipp Guendisch <philipp.guendisch@fau.de>
> >> Signed-off-by: Chris Baller <chris.baller@gmx.de>
> >
> > Hi Philipp,
> >
> > Neither of the patches still applies?
> >
> > Are you sure you rebased them on the atomisp branch?
> >
> > --
> > Regards,
> >
> > Sakari Ailus
> > e-mail: sakari.ailus@iki.fi XMPP: sailus@retiisi.org.uk
>
> Hi Ailus,
>
> Unfortunately I dont know exactly why the patches did not apply.
>
> I tried a rebase with:
>
> "git remote add sailus-mediatree git://linuxtv.org/sailus/media_tree.git <git://linuxtv.org/sailus/media_tree.git>
> git fetch sailus-mediatree
> git checkout atomisp”
>
> Maybe I took too much time for rebasing and some patches were accepted between my ‘git pull’ and 'git send-email'
>
> I did another git pull right now and have seen the pathches are already in the commit history.
>
> So I think it's time to give you a huge THANK YOU!

You're welcome, and thank you for the cleanup patches!

This was my mistake actually; I thought the patches didn't apply but I
ended up trying to apply them... twice. That's what you get when you have
too many atomisp patches. :-o

>
> If I got it wrong and threre is still some work to do for the two patches please let me know
> and I will try to fix it.
>
> PS: I am totally new to kernel development yet.

Cleanup patches are a really good way to start, besides fixing small issues
here and there. :-)

--
Kind regards,

Sakari Ailus
e-mail: sakari.ailus@iki.fi XMPP: sailus@retiisi.org.uk

\
 
 \ /
  Last update: 2017-07-17 23:32    [W:0.039 / U:0.256 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site